Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make writing audio frames optional #216

Merged

Conversation

makaveli10
Copy link
Collaborator

Fixes #141

@makaveli10 makaveli10 changed the title Feature/writing audio frames optional Make writing audio frames optional May 28, 2024
Signed-off-by: makaveli10 <[email protected]>
whisper_live/transcriber.py Outdated Show resolved Hide resolved
whisper_live/transcriber.py Outdated Show resolved Hide resolved
whisper_live/transcriber.py Outdated Show resolved Hide resolved
Copy link
Contributor

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@makaveli10 makaveli10 merged commit e1a42c2 into collabora:main May 29, 2024
11 checks passed
@makaveli10 makaveli10 deleted the feature/writing_audio_frames_optional branch May 29, 2024 03:40
@makaveli10 makaveli10 restored the feature/writing_audio_frames_optional branch May 29, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Why is writing frames to disk no optional?
2 participants