Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the "av" library instead, which "just makes sense" since
faster-library
already uses it anyways. This removes thepyaudio
dependency as well as that ofscipy
andnumpy
. It also obviates users having to install ffmpeg sinceav
is basically a wrapper for ffmpeg.Here's what the
faster-whisper
repo says about it:I didn't have the time to analyze other scripts for their use of
pyaudio
,ffmpeg
via command line,scipy
, etc., but I image that there are places you can useav
instead to make things faster, easier for the user, and to simplify the code and reduce the amount of requirements.It also uses PathLib instead of string manipulation. I'm a big fan of pathlib because of its syntax and it's more platform independent.
As always, let's discuss before implementing!