Supported new mode: SCREEN_ANIMATION #531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijstriemstra
requested changes
Dec 26, 2020
|
Hi,
I will do it as soon as possible. and also respond to your other email
regarding the issue as soon as possible. Little busy today.
Mayank Kumar Chaudhari
…On Sat, Dec 26, 2020 at 10:24 PM Thijs Triemstra ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In package-lock.json
<#531 (comment)>
:
> @@ -2592,9 +2592,9 @@
"dev": true
can you revert the changes to package-lock.json as well
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#531 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGCR4VJYU6KS5L5MFHJM5BDSWYIKZANCNFSM4VH3VP5Q>
.
|
|
Hi, sorry for delay. I am not able to create a new pull request now. |
|
thanks for the pull request @mayank1513. While it's a good suggestion, I'd rather not expand on the old, buggy gif-recorder currently used in videojs-record to create animated GIFs. I started a new implementation, using gifshot (#292), but ran into other issues and the fact that that library is also not maintained anymore. Eventually we'll find a better implementation but I'm hesitant to build new things on top of the gif-recorder... thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I realized that screen could only be captured as video and not as animated gif. Thus, I added a new mode. No changes in the options object.
Earlier, if options object contained
animated: true,screenoption would be ignored. Now, by default screen is recorded as video but one can override this by adding animation options to turn it intogif.Hope this helps.