Fix check permissions in civicrm_api call #1019
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I found that with my setup searching for existing contacts by city did not work.
After fideling around I found that checkpermissions was not set
FALSE
before calling the civicrm_api4.Technical Details
This was due to the behaviour of
+=
for php arrays, which won't overwrite existing elements.As the element
$params['checkPermissions']
was set true earlier, the element was not overwritten by+=
and so the explicit join did not work.I added a quick fix, setting the element in the common way. Also one other function.
Comments
However I found, that the extension is using
+=
quit often. But I wonder if there is a need for it?