Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripetest - remove call to deprecated function #1001

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

demeritcowboy
Copy link
Collaborator

@demeritcowboy demeritcowboy commented Sep 8, 2024

Overview

Before

Call to function that:

  1. Is deprecated since 1.5 years
  2. All it does is create a payment processor
  3. Stripe doesn't use it, and webform is the only thing in universe that uses it.

After

  1. Just create a payment processor.
  2. Also allow for getting the keys via ENV or a DEFINE, which while they are test keys makes it easier to hide them in github actions by using github secrets.

Technical Details

Comments

@KarinG KarinG merged commit 7cb6051 into colemanw:6.x Sep 16, 2024
4 checks passed
@demeritcowboy demeritcowboy deleted the stripe branch September 16, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants