Add better naming and CFML interop with CFML Arrays and Structs #8
Conversation
lucee@5 ColdBox be Test Results46 tests 46 ✅ 0s ⏱️ Results for commit e4ae0b7. ♻️ This comment has been updated with latest results. |
lucee@5 ColdBox ^6.0.0 Test Results46 tests 46 ✅ 0s ⏱️ Results for commit 315c292. |
lucee@5 ColdBox ^6.0.0 Test Results46 tests 46 ✅ 0s ⏱️ Results for commit e4ae0b7. ♻️ This comment has been updated with latest results. |
adobe@2018 ColdBox ^6.0.0 Test Results45 tests 45 ✅ 0s ⏱️ Results for commit e4ae0b7. ♻️ This comment has been updated with latest results. |
adobe@2023 ColdBox ^6.0.0 Test Results45 tests 44 ✅ 0s ⏱️ For more details on these failures, see this check. Results for commit 315c292. |
adobe@2018 ColdBox be Test Results45 tests 45 ✅ 0s ⏱️ Results for commit e4ae0b7. ♻️ This comment has been updated with latest results. |
adobe@2023 ColdBox ^6.0.0 Test Results45 tests 45 ✅ 0s ⏱️ Results for commit e4ae0b7. ♻️ This comment has been updated with latest results. |
adobe@2021 ColdBox ^6.0.0 Test Results45 tests 45 ✅ 0s ⏱️ Results for commit e4ae0b7. ♻️ This comment has been updated with latest results. |
adobe@2021 ColdBox be Test Results45 tests 45 ✅ 0s ⏱️ Results for commit e4ae0b7. ♻️ This comment has been updated with latest results. |
elpete
force-pushed
the
better_cfml_interop
branch
from
315c292 to
e4ae0b7
Compare
| * | ||
| */ | ||
| function collectAsArray(){ | ||
| return arraySlice( variables.jStream.collect( variables.Collectors.toList() ), 1 ); |
There was a problem hiding this comment.
Are you sure with 1 it works in Java arrays? and not 0?
There was a problem hiding this comment.
Yes, it does. It is mostly used to convert the Java array to a CFML array.
This PR tries to achieve better CFML interop in two ways.
getNativeArrayandcollectToMap.collectToArrayto return CFML collections natively.The one potential breaking change was that I changed
collectToStructto return a native CFML struct instead of aHashMap. This shouldn't actually break anything since you can call all of theHashMapmethods on a CFML struct anyway, just not the other way around.