Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Type Check Fix #37

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

jeff-chastain
Copy link
Contributor

Fixes an issue in the newly introduced code to check the 'type' property of the mail object when parsing the tokens. 'Type' is not a required property of the mail object, so there are conditions when this property does not exist and therefore this code causes an error.

Description

Please include a summary of the changes and which issue(s) is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Please note that all PRs must have tests attached to them

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Issues

All PRs must have an accompanied issue. Please make sure you created it and linked it here.

Type of change

Please delete options that are not relevant.

  • Bug Fix

Checklist

  • My code follows the style guidelines of this project cfformat
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Fixes an issue in the newly introduced code to check the 'type' property of the mail object when parsing the tokens.  'Type' is not a required property of the mail object, so there are conditions when this property does not exist and therefore this code causes an error.
@lmajano lmajano merged commit b500f9f into coldbox-modules:development Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants