Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous design improvements #82

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

danieldaquino
Copy link

@danieldaquino danieldaquino commented May 8, 2024

This pull request implements several miscellaneous design changes in an attempt to improve the overall feel of the website.

Changes include:

  • Several tweaks to the theme and the colours used on both light and dark mode
  • Improvements to the responsiveness of the design (i.e. how well it handles screen size changes)
  • Other misc tweaks (e.g. Added spaces after factory hash where it was inconsistent)
  • Improved visual hierarchy through the use of spacing, font sizing, and colors.

The changes were taken in a way to improve design while maintaining the project's vibe, code style, framework of choice, and structure and familiarity, to avoid disruptions with other maintainers as much as possible.

Light mode preview

Before

Screenshot 2024-05-07 at 20 06 42

After

Screenshot 2024-05-07 at 20 07 20

Dark mode preview

Before

Screenshot 2024-05-07 at 20 06 54

After

Screenshot 2024-05-07 at 20 07 48

I also published a preview of the new version here — to make it easy to preview what it looks like after the changes: Older preview Latest preview
(Note: I did not upload the whole repo, links may not work in that preview)

Please let me know if you like this, or if you'd like any changes.

Thanks!

This improves structure of the page
This commit makes some improvements to the overall theme, color scheme,
and spacing and sizing of different elements
Improved web page responsiveness slightly, by automatically reducing the
size of the header on smaller screens, adding padding to the sides of
the page content, and making long hashes break into new lines when they
do not fit on a single line
@nvk
Copy link
Contributor

nvk commented May 8, 2024

Very nice. Is the orange on white legible enough?

Also, might take a little white to review the diff due to the nature of this project

This commit darkens the orange links on light mode to improve contrast
and legibility.

The new color has been checked to have a 4.5:1 contrast ratio on white
backgrounds, which is the minimum recommended by WCAG 2.1 AA for visual
presentation of text
(https://www.w3.org/WAI/WCAG21/Understanding/contrast-minimum.html)

The color contrast was calculated using https://color.adobe.com/create/color-contrast-analyzer
@danieldaquino
Copy link
Author

Very nice. Is the orange on white legible enough?

That's a good point, I went and checked with a color contrast tool, and that orange indeed did not have enough contrast against the white background. I added a new commit that changes the text color to a darker tone of orange which follows the minimum recommended contrast ratio (according to this standard). Here is a preview of this new version: https://663d01ca125be011afa176e6--sage-parfait-0b691d.netlify.app

Also, might take a little white to review the diff due to the nature of this project

Makes sense! I tried to organize the PR into logical commits to hopefully make reviewing easier, but please let me know if there is something I can do to make this process easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants