Skip to content
This repository has been archived by the owner on Jun 22, 2020. It is now read-only.

Implement TraderOne Exchange #1918

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

TraderOneDevs
Copy link

  • What is the purpose of this Pull Request?
    Implement TraderOne Exchange
  • What is the related issue for this Pull Request (if this PR fixes issue, prepend with "Fixes" or "Closes")?
  • [✓ ] I have added Specs
  • [✓ ] (If implementing Market Ticker) I have verified that the volume refers to BASE
  • [✓ ] (If implementing Market Ticker) I have verified that the base and target is assigned correctly
  • [✓ ] I have implemented the trade_page_url method that links to the exchange page with the base and target passed in. If not available, enter the root domain of the exchange website.
  • [ ✓] I have verified at least ONE ticker volume matches volume shown on the trading page (use script below)
client = Cryptoexchange::Client.new
pairs = client.pairs 'exchange_name'
tickers = pairs.map do |p| client.ticker p end
sorted_tickers = tickers.sort_by do |t| t.volume end.reverse

Copy link
Author

@TraderOneDevs TraderOneDevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've fixed the market.rb. Could you re-verify the checks?

Copy link
Author

@TraderOneDevs TraderOneDevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit to get travis to re-run

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant