Skip to content
This repository has been archived by the owner on Jun 22, 2020. It is now read-only.

Add CPUfinex exchange #1722

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add CPUfinex exchange #1722

wants to merge 1 commit into from

Conversation

minkcrypto-zz
Copy link

@minkcrypto-zz minkcrypto-zz commented Aug 26, 2019

  • What is the purpose of this Pull Request?

### Add CPUfinex exchange https://cpufinex.com/exchange/BTC-USDT to CoinGecko

  • What is the related issue for this Pull Request (if this PR fixes issue, prepend with "Fixes" or "Closes")?

I've already submitted the google form for our exchange

  • I have added Specs
  • (If implementing Market Ticker) I have verified that the volume refers to BASE
  • (If implementing Market Ticker) I have verified that the base and target is assigned correctly
  • I have implemented the trade_page_url method that links to the exchange page with the base and target passed in. If not available, enter the root domain of the exchange website.
  • I have verified at least ONE ticker volume matches volume shown on the trading page (use script below)
client = Cryptoexchange::Client.new
pairs = client.pairs 'exchange_name'
tickers = pairs.map do |p| client.ticker p end
sorted_tickers = tickers.sort_by do |t| t.volume end.reverse

@minkcrypto-zz
Copy link
Author

Please check @wenjieyek @wongy91 @tmlee @ElvisLYC

@wongy91
Copy link
Contributor

wongy91 commented Sep 10, 2019

website shows 0 volume. Unable to verify volume

@minkcrypto-zz
Copy link
Author

@wongy91 Can you recheck it please?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants