chore: release #1279
Merged
chore: release #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xAlec
force-pushed
the
alec/release919
branch
from
8ae47d4
to
de12897
Compare
fakepixels
reviewed
Sep 19, 2024
.changeset/nervous-lamps-jog.md
Outdated
| Updated `LifecycleStatus` in `Swap` component for swaps from ERC-20 tokens. | ||
| Previously, there were 2 transactions when swapping from an ERC-20 token. | ||
| Now, there is an extra approval. (Approve ERC-20 against Permit2 -> Approve Uniswap to spend the approved ERC-20s on Permit2 -> Execute Swap Transaction) | ||
| If you're listening to the `LifecycleStatus` in `Swap`, please make sure your app accounts for the extra transaction. |
There was a problem hiding this comment.
Should we provide some guidance on how to do so for apps in our docs?
fakepixels
approved these changes
Sep 19, 2024
abcrane123
approved these changes
Sep 19, 2024
0xAlec
force-pushed
the
alec/release919
branch
from
de12897
to
faaae7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?