docs: SwapSettings #1265
Merged
docs: SwapSettings #1265
+381
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cpcramer
force-pushed
the
paul/add-swap-settings-slippage-docs
branch
from
6512503
to
1448ac5
Compare
cpcramer
force-pushed
the
paul/add-swap-settings-slippage-docs
branch
from
7c3d1d2
to
acb9a08
Compare
0xAlec
approved these changes
Sep 17, 2024
Zizzamia
reviewed
Sep 18, 2024
Zizzamia
reviewed
Sep 18, 2024
Zizzamia
reviewed
Sep 18, 2024
| The `SwapSettings` component allows users to configure the maximum acceptable price difference (slippage) for their token swap transactions. | ||
| It provides a simple interface to set and adjust this tolerance level. | ||
|
|
||
| ## Usage |
There was a problem hiding this comment.
Let's rewrite all of this as Steps and story telling, like we have here https://onchainkit.xyz/transaction/transaction
There was a problem hiding this comment.
Synced with Tina - Going to merge this"v1" now to focus on trying to get USD values in before the release tomorrow.
After USD values are implemented I will update SwapSettings to the story telling design that we have for /transaction
There was a problem hiding this comment.
Update - merging this PR after Thursday's release. There is a icon bug fix that we need
cpcramer
force-pushed
the
paul/add-swap-settings-slippage-docs
branch
from
acb9a08
to
f670580
Compare
cpcramer
force-pushed
the
paul/add-swap-settings-slippage-docs
branch
from
b1ef9fd
to
332b1f8
Compare
abcrane123
approved these changes
Sep 18, 2024
alessey
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Add
SwapSettingsdocs coveringSwapSettings,SwapSettingsSlippageDescription,SwapSettingsSlippageInput, andSwapSettingsSlippageTitle.Examples include general usage, overriding styles, overriding icons, adding text, and updating text!
Notes to reviewers
How has it been tested?