Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): explicit vitest imports #1252

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

avidreder
Copy link
Contributor

What changed? Why?

  • There were many instances of missing imports in test files and imports of types from the vi namespace
  • Adds missing vi imports, changes instances of vi.Mock to use imported type from package

Notes to reviewers

  • There are no functional changes to code or tests, this is mostly an exercise in standardization, as there was a mix of import styles

How has it been tested?

  • CI

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 3:32am
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 3:32am

Copy link

vercel bot commented Sep 13, 2024

@avidreder is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@Zizzamia Zizzamia merged commit 0435fa0 into coinbase:main Sep 13, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants