feat: add template #1 - quickstart #4
Conversation
abcrane123
changed the title
|
|
||
| /* i believe this is necessary because | ||
| of a div added by rainbowkit provider */ | ||
| body > div { |
There was a problem hiding this comment.
I can see junior developer tripping on this.
Can we do this in a more simple way?
There was a problem hiding this comment.
hmmm i couldn't really think of anything better because it is a hidden div without a classname. do you have an idea?
There was a problem hiding this comment.
so are you trying to target what in particular? the first div after the body ?
| } | ||
|
|
||
| .ockConnectWallet_Container span { | ||
| color: #030712; |
There was a problem hiding this comment.
Let's start introducing CSS variables
src/components/BaseSvg.tsx
Outdated
| @@ -0,0 +1,18 @@ | |||
| export default function BaseSvg() { | |||
There was a problem hiding this comment.
let's start introducing a svg folder. It will end up useful as we use this template for future more complex templates.
src/components/Footer.tsx
Outdated
| <section className="mt-12 mb-6 flex w-full flex-col justify-between gap-2 md:flex-row "> | ||
| <aside className="flex items-center justify-center md:justify-start"> | ||
| <h3 className="mr-2 text-m">Built with love on</h3> | ||
| <BaseSvg /> |
There was a problem hiding this comment.
I think is best we say, Built with love by the OnchainKit team. And avoid mentioning Base, as this is a repo done by Coinbase.
src/components/Footer.tsx
Outdated
| <ul className="flex justify-center gap-6 md:justify-start"> | ||
| {docLinks.map(({ href, title }) => ( | ||
| <li className="flex" key={href}> | ||
| <a href={href} target="_blank" rel="noreferrer"> |
There was a problem hiding this comment.
title is missing, which is critical for SEOs.
| } from '@coinbase/onchainkit/transaction'; | ||
| import type { Address, ContractFunctionParameters } from 'viem'; | ||
|
|
||
| const clickContractAddress = '0x67c97D1FB8184F038592b2109F854dfb09C77C75'; |
There was a problem hiding this comment.
Let's move those into a constants file in src
src/wagmi.ts
Outdated
| ], | ||
| { | ||
| appName: 'onchainkit', | ||
| projectId: 'b9c838acbe76023b550d93eae506c69b', |
There was a problem hiding this comment.
This should come from the ENV file. And never commited.
What changed? Why?
Notes to reviewers
How has it been tested?