feat: implement mini-batch & continue-as-new for replicator workflow #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bestmike007 <[email protected]>
bestmike007
force-pushed
the
feat/replicator-workflow-mini-batch
branch
from
0e55041 to
eafabbb
Compare
HenryYYang
reviewed
Feb 23, 2024
Signed-off-by: bestmike007 <[email protected]>
bestmike007
force-pushed
the
feat/replicator-workflow-mini-batch
branch
from
80f810f to
7a47879
Compare
HenryYYang
reviewed
Feb 25, 2024
| BlockHeight uint64 | ||
| Tag uint32 | ||
| BlockHeight uint64 | ||
| ValidateSince uint64 |
There was a problem hiding this comment.
nit: maybe validateStart would be a better name. Please also add a comment on whether this is inclusive or exclusive index.
Signed-off-by: bestmike007 <[email protected]>
HenryYYang
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
How did you test the change?
go run ./cmd/admin workflow start --workflow replicator --input '{"StartHeight": 1, "EndHeight": 10001}' --blockchain ethereum --network mainnet --env local