Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sessionToken parameter support to initOnRamp #306

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tomaszbakula
Copy link

@tomaszbakula tomaszbakula commented Sep 17, 2024

Description & motivation

I propose extending the initOnRamp function by introducing support for a sessionToken parameter. This would allow users to initialize the function using either sessionToken or appId.

To ensure this update is fully integrated, I’ve updated the TypeScript types to include sessionToken as a valid parameter, maintaining type safety throughout the codebase. Additionally, I’ve written new test cases to confirm that the sessionToken functionality works as expected and that there are no regressions with the current implementation.

This change would enhance the current functionality without disrupting the existing workflow for those using appId.

Also, the generateOnRampURL() should be able to generate a URL based on the sessionToken only. If sessionToken has been specified, there is no need to provide the addresses parameter. Currently, it does work, and it's been fixed in this MR.

Do you think this kind of update would fit with the project’s goals and be something worth including?

Testing & documentation

I've covered adding the sessionToken parameter with the unit test.

@tomaszbakula
Copy link
Author

@steveviselli-cb, is there any chance you could have a look into this, please? Thanks.

@steveviselli-cb
Copy link
Contributor

Hey @tomaszbakula, we're actually migrating this repo over to OnchainKit, the first release went out today! https://github.com/coinbase/onchainkit/releases/tag/v0.33.3

It's not at 100% feature parity yet, but we are focusing our efforts there. It does support passing sessionToken. The docs haven't been updated yet, but will be very soon.

@tomaszbakula
Copy link
Author

@steveviselli-cb Thank you for the detailed response! Does this mean that you will no longer be accepting any changes to this repository, or is there still room for contributions until OnchainKit reaches full feature parity?

@steveviselli-cb
Copy link
Contributor

@tomaszbakula yeah sorry, we won't be accepting any more changes to this repo. We will officially end of life it soon and move everything to OnchainKit.

Copy link

@Billiej88 Billiej88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/utils/CoinbasePixel.test.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants