Add support for MaxNode option with CBC solver #580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Pinging @pchtsp to check if there's any update on this PR :) For reference, I've been using the change in this fork since raising the PR and it has been working fine |
pchtsp
requested changes
Mar 12, 2023
| @@ -205,6 +205,7 @@ def __init__( | |||
| self.msg = msg | |||
| self.options = options | |||
| self.timeLimit = timeLimit | |||
| self.maxNodes = maxNodes | |||
There was a problem hiding this comment.
as the comment two lines below says, the maxNodes attribute is stored inside the self.optionsDict attribute.
| @@ -167,6 +170,8 @@ def solve_CBC(self, lp, use_mps=True): | |||
| cmds += f"mips {tmpMst} " | |||
| if self.timeLimit is not None: | |||
| cmds += f"sec {self.timeLimit} " | |||
| if self.maxNodes is not None: | |||
There was a problem hiding this comment.
As the other comment says, this attribute does not exist. You should thus do something like:
maxNodes = self.optionsDict.get("maxNodes")
if maxNodes is not None:
cmds += f"maxNodes {maxNodes} "
|
sorry for the troubles, I've added the maxNodes argument as explained in the comments #690. I'm closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for the
maxNodesoption for the CBC solver. Includes a simple test to make sure the option is implemented correctly.I originally tried to create a test to show that using the
maxNodesoption would cause the CBC solver to terminate upon reaching that number of nodes, but couldn't find an intuitive way to read theEnumerated Nodesor "stopping reason" outputs of the sovler in test cases.