Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use list length for range function #25

Closed
wants to merge 1 commit into from

Conversation

cupOJoseph
Copy link

No description provided.

@cupOJoseph
Copy link
Author

fixes #24, although there are other syntax issues.

@SweetmanTech
Copy link

I'm excited to see this implemented!

Do we know why it is taking IBM team so long to review?

Nearly 2 months without merging.

Maybe we need to assign merger?

image

@SweetmanTech
Copy link

Assign Pull Requests to: amchaney

@cupOJoseph
Copy link
Author

I think there are some other issues too. I solved that one thing but had other bugs, never actually got it running... wish it worked

@SweetmanTech
Copy link

:( does IBM still support this? @amchaney ?

@amchaney
Copy link
Collaborator

Hey, IBM has never supported this. I did this in my free time, and testing a one line range check change hasn't been on the top of my personal time recently. If you tried it @SweetmanTech and it didn't break your build, I'd merge it, but @jschiarizzi also said he never got it running completely, so really I'd prefer to wait on a full fix before I review a PR.

@amchaney
Copy link
Collaborator

FYI, this was never supported under Windows, so if you want feel free to manage your own branch that's why it is open sourced :-)

@amchaney amchaney closed this Dec 31, 2019
@cupOJoseph
Copy link
Author

Probably a good idea since I never got it running properly. :)

Maybe it will help someone getting it running elsewhere though, as a reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants