Skip to content

Commit

Permalink
fix gha reviewdog workflow so it actually uses go 1.17
Browse files Browse the repository at this point in the history
it was installing 1.18 which can panic or have a variety of silent failures.
See: reviewdog/action-golangci-lint#249
  • Loading branch information
cognifloyd committed Apr 21, 2022
1 parent c253398 commit c6e2fc4
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/reviewdog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ name: reviewdog
on:
pull_request:

# NOTE: We have to specify `go_version: 1.17` because the action was installing 1.18.
# 1.18, in turn, is not fully supported by golangci-lint yet, and it can fail silently:
# see: https://github.com/reviewdog/action-golangci-lint/issues/249

# pipeline to execute
jobs:
diff-review:
Expand All @@ -19,6 +23,7 @@ jobs:
uses: reviewdog/action-golangci-lint@v2
with:
github_token: ${{ secrets.github_token }}
go_version: 1.17
golangci_lint_flags: "--config=.golangci.yml"
fail_on_error: true
filter_mode: diff_context
Expand All @@ -36,6 +41,7 @@ jobs:
uses: reviewdog/action-golangci-lint@v2
with:
github_token: ${{ secrets.github_token }}
go_version: 1.17
golangci_lint_flags: "--config=.golangci.yml"
fail_on_error: false
filter_mode: nofilter

0 comments on commit c6e2fc4

Please sign in to comment.