Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show alert for critical battery #104

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

yatharth
Copy link

@yatharth yatharth commented Jul 11, 2016

This PR addresses #103:

Feature Request: Could there be an option to have a pop-up or a dialog box when your battery drops below a certain level?

I wanted to feature enough to hack it together myself right then. ‘Hack’ as I’ve never written Objective C code before; I worked off of this PR.

The alert doesn’t steal keyboard focus. When it is active, the menu bar item can be activated but not interacted with.

@yatharth
Copy link
Author

yatharth commented Jul 11, 2016

Re localization: I have wrapped my strings in NSLocalizedString (and provided appropriate context), but I have not done anything else. I don’t know if I should have (but maybe I could try if given a pointer?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant