Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[astro-seo-meta] Add siteName to Facebook metadata component #854

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

NekoSakuraLucia
Copy link
Contributor

Update Details

We have added the siteName feature in the Facebook Meta of the Seo.astro and Facebook.astro files. This feature allows specifying the website's name in Facebook metadata, improving the display of shared content on the Facebook platform.

Added Features

Feature Updated Files Description
siteName Seo.astro Added support for specifying the website name in Facebook metadata.
siteName Facebook.astro Supports adding siteName for displaying the website name.

Update Timeline

📅 2025-01-17: Added `siteName` feature in Facebook Meta
    - Updated Files: `Seo.astro`, `Facebook.astro`
    - Feature: Added support for `siteName` in metadata for displaying the website name on Facebook.

Copy link

changeset-bot bot commented Jan 17, 2025

🦋 Changeset detected

Latest commit: 602d32a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro-seo-meta Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

NekoSakuraLucia and others added 2 commits January 17, 2025 16:11
@mhdcodes
Copy link
Member

hey @NekoSakuraLucia, thanks for this PR.

i'm not sure about this change since it's not mentioned in the official facebook reference: https://developers.facebook.com/docs/sharing/webmasters#markup

while it is part of the open graph protocol, each platform decides what to implement, so i'm unsure if this tag is actually supported.

@mhdcodes mhdcodes changed the title [astro-seo-meta] Added the configuration for siteName in Facebook metadata and other. [astro-seo-meta] Add siteName to Facebook metadata component Jan 17, 2025
Copy link

pkg-pr-new bot commented Jan 17, 2025

Open in Stackblitz

npm i https://pkg.pr.new/codiume/orbit/astro-seo-meta@854
npm i https://pkg.pr.new/codiume/orbit/astro-purgecss@854
npm i https://pkg.pr.new/codiume/orbit/astro-useragent@854

commit: 602d32a

@mhdcodes mhdcodes added the astro-seo-meta Issues related to astro-seo-meta package label Jan 17, 2025
@NekoSakuraLucia
Copy link
Contributor Author

NekoSakuraLucia commented Jan 17, 2025

hey @NekoSakuraLucia, thanks for this PR.

i'm not sure about this change since it's not mentioned in the official facebook reference: https://developers.facebook.com/docs/sharing/webmasters#markup

while it is part of the open graph protocol, each platform decides what to implement, so i'm unsure if this tag is actually supported.

The use of the og:site_name tag is part of the Open Graph Protocol, and Facebook supports this tag to display the name of the website from which the content originates when shared on the Facebook platform or other services that support Open Graph.

@mhdcodes
Copy link
Member

mhdcodes commented Jan 17, 2025

the thing is, as I mentioned, not all open graph tags are supported by Facebook some og:tags are just skipped. do you have any way to confirm if this tag is actually supported? as you know, i prefer not to add anything unnecessary. i’ve ensured this package includes only the minimal set of supported tags.

@NekoSakuraLucia
Copy link
Contributor Author

@mhdcodes Actually, the og:site_name tag is not explicitly mentioned in Facebook's Open Graph documentation. However, based on practical usage, this tag is generally supported and is used to display the website name when sharing a link on Facebook. You can try debugging it yourself using a tool to test meta tags. If I’m not mistaken, there’s a website for testing this.

@mhdcodes
Copy link
Member

yeah there are websites to try this, I will do the testing and let you know. thanks for the great work @NekoSakuraLucia

@NekoSakuraLucia
Copy link
Contributor Author

okay, bro

@mhdcodes mhdcodes self-assigned this Jan 17, 2025
@mhdcodes mhdcodes self-requested a review January 17, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astro-seo-meta Issues related to astro-seo-meta package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants