This repository has been archived by the owner on Jul 17, 2020. It is now read-only.
Scaffold entities #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asynts
reviewed
Mar 21, 2020
asynts
reviewed
Mar 21, 2020
asynts
reviewed
Mar 21, 2020
asynts
reviewed
Mar 21, 2020
Co-Authored-By: Paul Scharnofske <[email protected]>
ArtOfCode-
suggested changes
Apr 2, 2020
ArtOfCode-
approved these changes
Apr 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request summary
Adds all the entities.
Adds all the configuration.
Scaffolded from - https://github.com/mcalexster/mcalex_codidact/blob/mcalex/skeleton/Database/Scripts/base/SchemaProposalCurrent_withGenCols.sql
After scaffolding I moved all the configuration files from the DbContext file to each separate configuration. I also added base classes to all the entities so to remove typos.
Also removed all redundant property renames from the configurations.
This took me around 4 hours so its not like you can delete everything back and scaffold it again.
This is why this is a draft.
Problem is the way I see it if I don't optimize it there is a lot of repeated code and redundant code.
Whats missing - Audit tables are not automatically filled on changes though this is fairly easy to do.
Link to Project Card/Issue
#18
Pull Request Tasklist
developbranch