[WIP] Java 21 upgrades #1005
Open
[WIP] Java 21 upgrades #1005
+51
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malmgrens4
commented
Jan 30, 2025
| @@ -0,0 +1 @@ | |||
| corretto64-21.0.4 | |||
malmgrens4
commented
Jan 30, 2025
| @@ -0,0 +1 @@ | |||
| corretto64-21.0.4 | |||
malmgrens4
commented
Jan 30, 2025
| @@ -65,6 +65,7 @@ | |||
| <configuration> | |||
| <instructions> | |||
| <Bundle-SymbolicName>${project.artifactId}</Bundle-SymbolicName> | |||
| <Require-Capability>osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.8))"</Require-Capability> | |||
malmgrens4
commented
Jan 30, 2025
| @@ -321,7 +321,7 @@ public int compare(Map.Entry<String, Object> entry1, Map.Entry<String, Object> e | |||
| public void init() { | |||
|
|
|||
| get( | |||
| "/compose/startup", | |||
| "/internal/compose/startup", | |||
There was a problem hiding this comment.
So the routes now require this, but only because of how jaxrs servers are registered in the new OSGI whiteboard web services model. There is a plan to replace those with spark servlets which can have their context configured. We won't need to rewrite all of these - so leaving it here for now, but after merging with work @glenhein has been doing we won't need it.
malmgrens4
commented
Jan 30, 2025
| @@ -85,7 +86,7 @@ | |||
|
|
|||
| <feature name="javalin" version="${project.version}" description="Javalin Web Framework"> | |||
| <feature prerequisite="true">wrap</feature> | |||
| <bundle>wrap:mvn:org.checkerframework/checker-qual/2.0.0$Bundle-Name=checker-qual&Bundle-SymbolicName=checker-qual&Bundle-Version=2.0.0&Export-Package=org.checkerframework.checker.nullness.qual;version="2.0.0"</bundle> | |||
| <!-- <bundle>wrap:mvn:org.checkerframework/checker-qual/2.0.0$Bundle-Name=checker-qual&Bundle-SymbolicName=checker-qual&Bundle-Version=2.0.0&Export-Package=org.checkerframework.checker.nullness.qual;version="2.0.0"</bundle>--> | |||
There was a problem hiding this comment.
This was giving me trouble on install. Will need to revisit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.