Add C++ Backend for BFS and Use std::variant for Graph Node Data #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prex03
commented
Jun 14, 2025
prex03
commented
- Added C++ implementations for DFS and BFS to improve traversal performance.
- Updated graph node data handling to use std::variant for type-safe storage.
- Adjusted Python bindings to support these backend changes.
czgdp1807
requested changes
Jun 15, 2025
| self->data_type = DataType::String; | ||
| self->data = std::string(str); | ||
| } else { | ||
| PyErr_SetString(PyExc_TypeError, "Unsupported data type. Must be int, float, str, or None."); |
There was a problem hiding this comment.
In other cases set to normal PyObject data type.
| @@ -13,7 +13,6 @@ typedef struct { | |||
| } AdjacencyMatrixGraphNode; | |||
|
|
|||
| static void AdjacencyMatrixGraphNode_dealloc(AdjacencyMatrixGraphNode* self){ | |||
| Py_XDECREF(self->super.data); | |||
There was a problem hiding this comment.
If it is PyObject then keep this inside if.
prex03
changed the title
added 2 commits
June 27, 2025 00:15
|
Tests for PyObject* type of data for nodes added in test_misc_util.py lines 39 and 47 |
czgdp1807
approved these changes
Jun 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.