feat: select component integration #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By this update Select Component was integrated into note's settings into Role Select component. Due to this integration, some issues were fixed: - added ability to get selected value outside the component via @value-update attribute - changed Popover's reactive styling to avoid unapplying component's positioning - Updated Select Component's page in Playground
Nothing special
neSpecc
reviewed
Jan 7, 2025
Some changes in Select behavior: - Now selected Item is two-binded, so it can be accessed outside the component easier and native - Added style properties: align to configure select's popover and isDisabled property to make component unaccessible in needed cases - Update Select's page on Playground according to its new interactions
After some manipulations on notes.api, it is possible to get creatorId directly as note property.
e11sy
reviewed
Jan 31, 2025
Now Popover's position contains px suffix with its values. This improvement solved problem with v-bind position in Popover 's styles
e11sy
reviewed
Feb 2, 2025
Removed unnecessary condition in role's watcher and updated info about creatorId field in Note type
e11sy
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By this update Select Component was integrated into note's settings into Role Select component, which fixes #284. Due to this integration, some other little issues were fixed: