Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(types): improve event type #105

Merged
merged 7 commits into from
Oct 13, 2024
Merged

chore(types): improve event type #105

merged 7 commits into from
Oct 13, 2024

Conversation

neSpecc
Copy link
Member

@neSpecc neSpecc commented Oct 12, 2024 •
edited
Loading

  1. Props of HawkJavaScriptEvent are not optional anymore since Catcher always sends them

It helps TS developers to work with event, for example in beforeSend method:

image
  1. Missed types (caused by .d.ts files ignoring in /dist) exports fixed
  2. Now Catcher sends its version via catcherVersion prop

@neSpecc neSpecc merged commit 7dd8c26 into master Oct 13, 2024
1 check passed
@neSpecc neSpecc deleted the impr-event-type branch October 13, 2024 18:47
@neSpecc neSpecc mentioned this pull request Oct 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TatianaFomina TatianaFomina TatianaFomina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neSpecc @TatianaFomina