Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update news.md #33

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Update news.md #33

merged 3 commits into from
Jan 2, 2024

Conversation

Sklujan
Copy link
Contributor

@Sklujan Sklujan commented Dec 13, 2023

Description:

[Provide a brief description of the changes in the pull request.]

Related Issue(s):

[Link to the related Issue(s), if any.]

Changes Included:

  • Bugfix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Refactoring (a change that improves code quality and/or architecture)
  • Other (explain below)

Implementation Details:

[Explain any new decisions made during the implementation of the changes.]

Testing:

[Describe how the changes have been tested.]

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codex-storage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 3:14pm

Copy link
Collaborator

@jessiebroke jessiebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks much better!

Some changes to make:

  • Change "Codex R&D Update for the week of 11" to "Codex R&D Update for Week of December 11, 2023" or similar format that includes month and year.
  • Formatting issues from lines 53 and 54.
  • Fix "DHTDht" on line 87.
  • Some items are not creating lists properly 50-58 (lines 50-52 use <> symbols for links and this is wrong and needs to be removed).
  • lines 65-67 have same issue as above w/ <> symbols

I made Jesse's corrections; please have another glance!
@jessiebroke jessiebroke merged commit 6d3958d into develop Jan 2, 2024
4 checks passed
@jessiebroke jessiebroke deleted the Sklujan-R&D-Update branch January 2, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants