Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy verifier #82

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Dummy verifier #82

merged 3 commits into from
Jan 31, 2024

Conversation

markspanbroek
Copy link
Member

Deploy 2 versions of the marketplace (only on local network):

  • Marketplace with Groth16 Verifier
  • Marketplace with TestVerifier

The test verifier accepts all proofs, except when it has all 0 values.
Necessary for testing the codex client, until we can generate real ZK proofs.

Removes the code that deploys contracts to a fixed address, because it doesn't seem to work, and I couldn't find a way to get it to work.

Copy link
Member

@AuHau AuHau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One with the real Groth16 verifier,
and one with a dummy verifier used for testing.
Contract aliasing (specifying a fixed address for a
contract) doesn't work. We're now echoing the
addresses of the deployed contracts instead.
@markspanbroek markspanbroek enabled auto-merge (rebase) January 31, 2024 14:44
@markspanbroek markspanbroek merged commit 31bbd70 into master Jan 31, 2024
4 checks passed
@markspanbroek markspanbroek deleted the mock-verifier branch January 31, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants