Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change constructor param to config #203

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions contracts/Marketplace.sol
Original file line number Diff line number Diff line change
Expand Up @@ -62,30 +62,24 @@ contract Marketplace is SlotReservations, Proofs, StateRetrieval, Endian {
}

constructor(
MarketplaceConfig memory configuration,
MarketplaceConfig memory config,
IERC20 token_,
IGroth16Verifier verifier
)
SlotReservations(configuration.reservations)
Proofs(configuration.proofs, verifier)
{
) SlotReservations(config.reservations) Proofs(config.proofs, verifier) {
_token = token_;

require(
configuration.collateral.repairRewardPercentage <= 100,
config.collateral.repairRewardPercentage <= 100,
"Must be less than 100"
);
require(config.collateral.slashPercentage <= 100, "Must be less than 100");
require(
configuration.collateral.slashPercentage <= 100,
"Must be less than 100"
);
require(
configuration.collateral.maxNumberOfSlashes *
configuration.collateral.slashPercentage <=
config.collateral.maxNumberOfSlashes *
config.collateral.slashPercentage <=
100,
"Maximum slashing exceeds 100%"
);
_config = configuration;
_config = config;
}

function configuration() public view returns (MarketplaceConfig memory) {
Expand Down