Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve backdrop position for hotspots element #2212

Merged
merged 32 commits into from
Mar 14, 2025
Merged

Improve backdrop position for hotspots element #2212

merged 32 commits into from
Mar 14, 2025

Conversation

tf
Copy link
Member

@tf tf commented Mar 13, 2025

REDMINE-20853

@tf tf added this to the v17.1 milestone Mar 13, 2025
tf added 25 commits March 14, 2025 08:20
@tf
Preserve tooltip and indicator aspect ratio in backdrop position
1da89d4 
REDMINE-20853
@tf
Prevent "ResizeObserver loop completed with undelivered notifications"
362b127 
REDMINE-20853
@tf
Restructure useScrollPanZoom return value
4c98943 
REDMINE-20853
@tf
Extract hotspots configuration setup into custom hook
e5e4e7f 
REDMINE-20853
@tf
Handle portrait area properties in one place
36806c8 
Prevent having to pass around portraitMode.

REDMINE-20853
@tf
Extract hotspots state into custom hook
78011ca 
REDMINE-20853
@tf
Enable request animation frame stub globally
68a5de5 
Prevent skipping code that is wrapped in `requestAnimationFrame` when
we forget to manually import the spec helper.

REDMINE-20853
@tf
Extend pan zoom calculations
173b541 
REDMINE-20853
@tf
Apply initial transforms to cover backdrop elements
4be68cf 
REDMINE-20853
@tf
Simplify usePanZoomScroller hook
099b0ba 
Extract all transform calulations to use usePanZoomTransforms.

REDMINE-20853
@tf
Move defaults to useHotspotsConfiguration
bc41770 
REDMINE-20853
@tf
Only mock pan zoom calculations in useScrollPanZoom spec
8f3161f 
REDMINE-20853
@tf
Only apply initial transforms if pan zoom or backdrop
3099f4b 
REDMINE-20853
@tf
Hide tooltips when backdrop element is intersecting
d7d4fa9 
REDMINE-20853
@tf
Extract Pager component from Hotspots
58eb209 
REDMINE-20853
@tf
Hide pager buttons and indicators when intersecting
f1e4275 
REDMINE-20853
@tf
Hide area outlines when intersecting
f68096b 
REDMINE-20853
@tf
Consider initial scale when panning to area in backdrop position
7017bb9 
When zoom has been set zero for an area, we do not want to zoom out
beyond the initial scale.

REDMINE-20853
@tf
Only apply initial transform in backdrop position
1c035a7 
REDMINE-20853
@tf
Reorder pan zoom calculation functions
b8052ff 
REDMINE-20853
@tf
Rename variables in pan zoom calculations
bc82f77 
Use base width/height to refer to the height of things in the
untransformed image.

REDMINE-20853
@tf
Refactor pan zoom calculations
5bd93f6 
REDMINE-20853
@tf
Prevent areas from intersecting with pager buttons in backdrop
3cbbb8a 
REDMINE-20853
@tf
Render blurry background for backdrop letter boxes
b16a6ee 
REDMINE-20853
@tf
Keep tooltips in viewport in backdrop position
2529745 
REDMINE-20853
tf added 3 commits March 14, 2025 08:20
@tf
Disable fullscreen option when using backdrop position
f01c506 
REDMINE-20853
@tf
Hide full width on mobile option for backdrop elements
a41f188 
REDMINE-20853
@tf
Make Safari happy
60edf74 
Safari messes up aspect-ratio calculations for children of stack
grid.

REDMINE-20853
@tf tf merged commit 5890bc0 into codevise:master Mar 14, 2025
22 of 23 checks passed
@tf tf deleted the bg-hotspot-2 branch March 14, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v17.1
Development

Successfully merging this pull request may close these issues.
1 participant
@tf