[YooN] 3/5(수)까지 작업할 PR #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SangYoonLee1231 PR을 main 브랜치로 보내셨어요~ |
crongro
reviewed
Mar 5, 2025
index.html
Outdated
| </div> | ||
| <!-- Task Card --> | ||
| <div class="task-card"> | ||
| <div class="task-card__title">Task 1</div> |
index.html
Outdated
| <img | ||
| class="column__header-right-icon" | ||
| src="./icons/plus.png" | ||
| alt="add task" |
index.html
Outdated
| <!-- Header --> | ||
| <header class="header"> | ||
| <div class="header__logo"> | ||
| <span class="header__logo-name">TASKIFY</span> |
앗 감사합니다! 제 브랜치로 수정했습니다 :) |
added 2 commits
March 5, 2025 12:50
crongro
approved these changes
Mar 6, 2025
Comment on lines
+23
to
+44
| <!-- Task Card --> | ||
| <!-- <div class="task-card"> | ||
| <div class="task-card__left"> | ||
| <div class="task-card__title">Task 1</div> | ||
| <div class="task-card__description">Description 1</div> | ||
| <div class="task-card__author">author by YooN</div> | ||
| </div> | ||
| <div class="task-card__right"> | ||
| <img | ||
| class="task-card__right-delete-icon" | ||
| src="./icons/delete.png" | ||
| width="14px" | ||
| alt="edit task" | ||
| /> | ||
| <img | ||
| class="task-card__right-modify-icon" | ||
| src="./icons/pen.png" | ||
| width="14px" | ||
| alt="delete task" | ||
| /> | ||
| </div> | ||
| </div> --> |
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| padding: 14.5px 16px; |
There was a problem hiding this comment.
디자인에 소수점이 있었나봐요?
가급적 소수점은 피하는것이 좋아요.
Comment on lines
+132
to
+133
| display: flex; | ||
| flex-direction: column; |
There was a problem hiding this comment.
레이아웃 관련된 비슷한 스타일이 자주 등장하면
레이아웃 클래스를 만들어서 사용하는 것도 좋죠.(유틸리티 클래스 )
| justify-content: space-between; | ||
| align-items: center; | ||
| padding: 14.5px 16px; | ||
| font-size: 16px; |
Comment on lines
+100
to
+101
| <h2 class="task-card__description">Description 1</h2> | ||
| <h3 class="task-card__author">author by YooN</h3> |
There was a problem hiding this comment.
h1은 페이지에 보통 한개 있는것이 좋고요.
h2,h3는 제목이라는 뜻인데 지금 내용이 제목 맞나요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 목록
메인 UI 구현
메뉴(히스토리) 구현
새로운 카드 등록 기능 구현
카드 이동
카드 삭제
카드 수정
카드 정렬