Pass callback to get provider options to provider_v26 constructor #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temeo
force-pushed
the
provider_options_cb
branch
from
d9b44fa to
1b7acab
Compare
sciascid
force-pushed
the
provider_options_cb
branch
from
a2c1a51 to
9349f85
Compare
Passing a callback allows constructing the options string using config service after loading the provider but before initializing the provider.
sciascid
force-pushed
the
provider_options_cb
branch
from
6bce0dc to
37de57e
Compare
Change provider_options so that it does not depend on provider. Call into config_service when provider is created, i.e. after library is loaded, before it is initialized, so that we can inject additional options at startup. Change the signature of the call provider options callback to take provider_options object as parameter.
sciascid
force-pushed
the
provider_options_cb
branch
from
a8222d8 to
db41d67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a callback allows constructing the options string using
config service after loading the provider but before initializing
the provider.