Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not abort prepared transaction when statement is interrupted #225

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

sciascid
Copy link
Contributor

@sciascid sciascid commented Mar 6, 2024

In transaction::abort_or_interupt() handle the case were a statement is interrupted while transaction is in prepared state. In which case, the transaction must remain in prepared state, until it is committed (or rolled back).
Also in this patch: remove check for reduntant s_must_abort state.

@sciascid sciascid force-pushed the fix-prepared-interrupted branch from 1a29fe2 to 381866d Compare March 6, 2024 17:17
Copy link

@janlindstrom janlindstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In `transaction::abort_or_interrupt()` handle the case were a statement
is interrupted while transaction is in prepared state. In which case,
the transaction must remain in prepared state, until it is
committed (or rolled back).
Also in this patch: remove check for reduntant `s_must_abort` state.
@sciascid sciascid force-pushed the fix-prepared-interrupted branch from 381866d to dfc4bdb Compare March 26, 2024 09:07
@sciascid sciascid merged commit dfc4bdb into master Mar 26, 2024
22 checks passed
@sciascid sciascid deleted the fix-prepared-interrupted branch March 26, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants