Skip to content
This repository was archived by the owner on May 9, 2020. It is now read-only.

verify rsa.Key object to prevent segfault #32

Merged
merged 2 commits into from
Jul 16, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions chef/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ def __init__(self, url, key, client, version='0.10.8', headers={}):
self.parsed_url = urlparse.urlparse(self.url)
if not isinstance(key, Key):
key = Key(key)
if not key.key:
raise ValueError("ChefAPI attribute 'key' was invalid.")
self.key = key
self.client = client
self.version = version
Expand Down
6 changes: 6 additions & 0 deletions chef/tests/test_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,9 @@ def test_env_variables(self):
self.assertEqual(api.client, 'foobar')
finally:
del os.environ['_PYCHEF_TEST_']

def test_bad_key_raises(self):
invalids = [None, '']
for item in invalids:
self.assertRaises(
ValueError, ChefAPI, 'foobar', item, 'user')