Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security rules for RSA key sizes and hard-coded secrets in Ruby and Rust #110

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+1,406 −0
Open

Add security rules for RSA key sizes and hard-coded secrets in Ruby and Rust #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc4ff6b
hardcoded-password-rust
Dec 12, 2024
fd36816
ruby-cassandra-hardcoded-secret-ruby
Dec 12, 2024
77415f8
insufficient-rsa-key-size-ruby
Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 91 additions & 0 deletions rules/ruby/security/insufficient-rsa-key-size-ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
id: insufficient-rsa-key-size-ruby
language: ruby
severity: warning
message: >-
The RSA key size $SIZE is insufficent by NIST standards. It is
recommended to use a key length of 2048 or higher.
note: >-
[CWE-326] Inadequate Encryption Strength.
[REFERENCES]
- https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-57Pt3r1.pdf
utils:
OpenSSL::PKey::RSA.generate($SIZE,...):
# OpenSSL::PKey::RSA.generate($SIZE,...)
kind: call
all:
- has:
stopBy: neighbor
kind: scope_resolution
regex: ^OpenSSL::PKey::RSA$
- has:
stopBy: neighbor
regex: ^.$
- has:
stopBy: neighbor
kind: identifier
regex: ^new|generate$
- has:
stopBy: neighbor
kind: argument_list
any:
- has:
stopBy: neighbor
kind: integer
pattern: $KEY
- has:
stopBy: neighbor
kind: float
pattern: $KEY
- has:
stopBy: neighbor
kind: unary
all:
- has:
stopBy: neighbor
regex: ^-$
- any:
- has:
stopBy: neighbor
kind: float
pattern: $KEY
- has:
stopBy: neighbor
kind: integer
pattern: $KEY
OpenSSL::PKey::RSA.new($ASSIGN, ...):
# $ASSIGN = $SIZE
# OpenSSL::PKey::RSA.new($ASSIGN, ...)
kind: call
all:
- has:
stopBy: neighbor
kind: scope_resolution
regex: ^OpenSSL::PKey::RSA$
- has:
stopBy: neighbor
regex: ^.$
- has:
stopBy: neighbor
kind: identifier
regex: ^new|generate$
- has:
stopBy: neighbor
kind: argument_list
has:
stopBy: neighbor
pattern: $BIT
- inside:
stopBy: end
kind: class
has:
stopBy: end
kind: assignment
pattern: $BIT = $KEY
rule:
kind: call
any:
- matches: OpenSSL::PKey::RSA.generate($SIZE,...)
- matches: OpenSSL::PKey::RSA.new($ASSIGN, ...)
constraints:
KEY:
regex: '^(-?(0|[1-9][0-9]?|[1-9][0-9]{2}|1[0-9]{3}|20[0-3][0-9]|204[0-7])(\.[0-9]+)?|0|-[1-9][0-9]*|-[1-9][0-9]{2,}|-1[0-9]{3}|-20[0-3][0-9]|-204[0-7])$'
127 changes: 127 additions & 0 deletions rules/ruby/security/ruby-cassandra-hardcoded-secret-ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,127 @@
id: ruby-cassandra-hardcoded-secret-ruby
language: ruby
severity: warning
message: >-
A secret is hard-coded in the application. Secrets stored in source
code, such as credentials, identifiers, and other types of sensitive data,
can be leaked and used by internal or external malicious actors. Use
environment variables to securely provide credentials and other secrets or
retrieve them from a secure vault or Hardware Security Module (HSM).
note: >-
[CWE-798] Use of Hard-coded Credentials.
[REFERENCES]
- https://cheatsheetseries.owasp.org/cheatsheets/Secrets_Management_Cheat_Sheet.html
utils:
Cassandra.cluster():
# Cassandra.cluster(..., password: "", ...)
kind: call
all:
- has:
stopBy: neighbor
kind: constant
regex: ^Cassandra$
- has:
stopBy: neighbor
regex: ^.$
- has:
stopBy: neighbor
kind: identifier
regex: ^cluster$
- has:
stopBy: neighbor
kind: argument_list
has:
stopBy: end
kind: pair
all:
- has:
stopBy: neighbor
kind: hash_key_symbol
regex: ^password$
- has:
stopBy: neighbor
kind: string
has:
stopBy: neighbor
kind: string_content
- inside:
stopBy: end
kind: program
has:
stopBy: end
kind: call
pattern: require 'cassandra'
Cassandra.cluster()_with_instance:
# Cassandra.cluster(..., password: "", ...)
kind: call
all:
- has:
stopBy: neighbor
kind: constant
regex: ^Cassandra$
- has:
stopBy: neighbor
regex: ^.$
- has:
stopBy: neighbor
kind: identifier
regex: ^cluster$
- has:
stopBy: neighbor
kind: argument_list
has:
stopBy: end
kind: pair
all:
- has:
stopBy: neighbor
kind: hash_key_symbol
regex: ^password$
- has:
stopBy: neighbor
kind: identifier
pattern: $SECRET
- inside:
stopBy: end
kind: program
has:
stopBy: end
kind: call
pattern: require 'cassandra'
- any:
- follows:
stopBy: end
kind: assignment
all:
- has:
stopBy: neighbor
kind: identifier
pattern: $SECRET
- has:
stopBy: neighbor
kind: string
has:
stopBy: neighbor
kind: string_content
- inside:
stopBy: end
kind: assignment
follows:
stopBy: end
kind: assignment
all:
- has:
stopBy: neighbor
kind: identifier
pattern: $SECRET
- has:
stopBy: neighbor
kind: string
has:
stopBy: neighbor
kind: string_content
ESS-ENN marked this conversation as resolved.
Show resolved Hide resolved
rule:
kind: call
any:
- matches: Cassandra.cluster()
- matches: Cassandra.cluster()_with_instance
Loading