-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for coder inbox #444
Conversation
Connect to Coder Inbox on /api/v2/notifications/watch to listen for notifications. Currently limit this to only show notifications for OOM/OOD notifications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look pretty good so far. Just had a few small bits of feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look pretty straightforward to me. Only thing I'm wondering is how hard it'd be to add tests
Closes coder/internal#337