Add Ubuntu version-specific tags for Docker images #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blink-so[bot]](https://avatars.githubusercontent.com/in/1271127?s=60&v=4){kind=small}
- Add support for Ubuntu version-specific tags (e.g., ubuntu-24.04, ubuntu-noble) - Modify build_images.sh to extract Ubuntu version from Dockerfile and create additional tags - Update push_images.sh to push version-specific tags to Docker Hub - Update README.md to document the new Ubuntu version-specific tags - Resolves issue with workspaces breaking when Ubuntu base version changes Co-authored-by: matifali <[email protected]>
Add missing blank line before code block in Ubuntu version tags documentation. Co-authored-by: matifali <[email protected]>
- Update build and push scripts to only support Ubuntu 24.04 (Noble) - Keep extensible structure for future Ubuntu version support - Add warning messages for unsupported Ubuntu versions - Update README to reflect current Ubuntu 24.04 only support Co-authored-by: matifali <[email protected]>
- Update Dockerfile to use ubuntu:24.04 instead of ubuntu:noble - Simplify build and push scripts to only create ubuntu-24.04 tags - Remove codename-based tags (ubuntu-noble) for simplicity - Update README to reflect simplified approach - Keep extensible structure for future Ubuntu versions Co-authored-by: matifali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #282 by adding Ubuntu version-specific tags to prevent workspaces from breaking when the base Ubuntu version changes.
Changes Made
build_images.sh: Added logic to extract Ubuntu version from Dockerfile and create additional version-specific tags (e.g.,ubuntu-24.04,ubuntu-noble)push_images.sh: Added functionality to push version-specific tags to Docker HubREADME.md: Documented the new Ubuntu version-specific tags with usage examplesHow It Works
When building Ubuntu images, the scripts now:
noble)noble→24.04)codercom/enterprise-base:ubuntu-24.04codercom/enterprise-base:ubuntu-nobleBenefits
ubuntutag continues to work as beforeTesting
Fixes #282