Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enterprise wrapper and image + ci #9

Merged
merged 8 commits into from
Aug 10, 2023
Merged

Conversation

deansheather
Copy link
Member

@deansheather deansheather commented Aug 7, 2023

  • Adds enterprise dir containing a wrapper binary functionally equivalent to exectrace in v1. This dir is licensed under the enterprise license.
  • Adds an enterprise pipeline for testing/building
  • Adds an enterprise-release pipeline for updating the image on GHCR

Closes coder/coder#8839
Closes coder/coder#5314

.github/workflows/quality.yml Outdated Show resolved Hide resolved
@@ -0,0 +1,32 @@
module github.com/coder/exectrace/enterprise
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need to be a separate module?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid imports from the enterprise module being added to the go.mod of any external packages that use only the parent package.

Copy link

@sreya sreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with this code but it LGTM

@deansheather deansheather merged commit be3c50a into main Aug 10, 2023
7 checks passed
@deansheather deansheather deleted the enterprise branch August 10, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wpl: move exectrace-v2 into extrace Workspace process logging
3 participants