impl: support uri handling #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reacts to uris like: jetbrains://gateway/com.coder.toolbox?url=https%3A%2F%2Fdev.coder.com&token=....&workspace=bobiverse-bill - the handling still does not work correctly when Toolbox is already running.
- reworked the main env provider to be able to close all existing resources and re-initialize with a different deployment - the re-initialization is needed in order to navigate to an env page with the targeted workspace. If the workspace is not from the current deployment there will be no env page to navigate to.
- a pop-up dialog is displayed asking for the deployment URL - an error dialog is displayed if the URL is still not provided by the user
- the existing code was trying indefinitely to ask for token until the user gets it right. This is not a bad idea, however Toolbox has a couple of limitations that make the existing approach almost unusable: - the input dialog doesn't allow custom actions through which we can spawn a browser at login page. The code always opened the login page when the token was wrong which ended up hammering the browser with too many tabs. - the token UI page can't be reused to request the login page (this one has a "Get token" action button) because once the user clicks on the Get token to open the webpage, Toolbox closes the window and forgets the last UI page that was visible. - instead with this patch we ask the token from the user only once. If something goes wrong (mostly during login) we show an error dialog and stop the flow.
- the error is also displayed when the workspace with the name does not exist
- starts and waits for the workspace to be running before showing the env page - improved error handling
- a service which orchestrates the IDE install, opening projects and so on
- when opening a URI, multiple polling jobs could be triggered on different Coder deployments if Toolbox starts from scratch. This happens because Toolbox takes longer to complete its initial plugin initialization, while the URI handling logic runs faster and doesn't wait properly for the plugin to be ready, leading to an early polling job. Meanwhile, once Toolbox finishes its initialization, it also triggers another polling job. - this patch properly waits for the plugin initialization and properly cancel the initial polling job, which is then replaced by the URI handling polling job.
- it's optional - `project_path` is the query param
- currently the uri handling waits for the plugin to fully initialize i.e. to sign in to the coder deployment and have the list of workspaces retrieved. - this is done in order to avoid scenarios were uri handling moves faster than autologin and polling and potentially ending up with more than one polling job - however if there is a manual login flow (for example if the user logs from the coder deployment we no longer autologin at the next startup) we don't have to wait for the initial polling job to be initialized.
matifali
approved these changes
Mar 21, 2025
| @@ -76,7 +75,7 @@ fun ensureCLI( | |||
|
|
|||
| // If downloads are enabled download the new version. | |||
| if (settings.enableDownloads) { | |||
| indicator?.invoke("Downloading Coder CLI...") | |||
| context.logger.info("Downloading Coder CLI...") | |||
There was a problem hiding this comment.
should we also log what version of CLI is being downloaded and the source URL?
There was a problem hiding this comment.
This is using https://dev.coder.com/bin/ to download the binary, and it doesn't contain the version. I think the version can be resolved only after running the cli, which means much later than this log.
- plus some clean-up for unused constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jetbrains://gateway/com.coder.toolbox?url=https%3A%2F%2Fdev.coder.com&token=....&workspace=bobiverse-billurl,tokenandworkspaceare mandatory. A fallback implementation is now provided where we ask for these parameters in case they were missing