Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add GitHub actions and remove Package wapproj #13

Merged
merged 7 commits into from
Jan 29, 2025

Conversation

deansheather
Copy link
Member

@deansheather deansheather commented Jan 28, 2025

Adds fmt, test and build jobs using dotnet.

The fmt job currently doesn't match what Rider does, but I think that will be difficult to pull off without using a different formatting tool which I don't want to investigate for now.

Removes the Package project in favor of making the App project include the necessary stuff for packaging itself. We weren't getting any benefit from it being in a separate package yet and it was not building correctly in dotnet (only in VS) when they were separated.

Closes #7

@deansheather deansheather changed the title chore: add GitHub actions chore: add GitHub actions and remove Package wapproj Jan 28, 2025
@deansheather deansheather marked this pull request as ready for review January 28, 2025 05:33
@deansheather
Copy link
Member Author

During the actual publish when we get release CI going, we probably want to make our build matrix manually specify RuntimeIdentifier and PublishReadyToRun on the publish command.

dotnet/sdk#39141


<Identity
Name="925b49fc-4648-4967-b4e6-b5473061ee62"
Publisher="CN=dean"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmfao oops, I guess it defaults to the current user

@deansheather deansheather merged commit 7f716c8 into main Jan 29, 2025
3 checks passed
@deansheather deansheather deleted the dean/actions branch January 29, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub Actions automation
2 participants