Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace spaces with hyphens in directory names #110

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Mar 12, 2025

Builds, passes tests, and a release build works: https://github.com/coder/coder-desktop-macos/actions/runs/13804258363

The main app target is still Coder Desktop, just not the names of any directories.

Copy link
Member Author

ethanndickson commented Mar 12, 2025

@ethanndickson ethanndickson self-assigned this Mar 12, 2025
@ethanndickson ethanndickson requested a review from ThomasK33 March 12, 2025 05:42
@ethanndickson ethanndickson marked this pull request as ready for review March 12, 2025 05:42
@ethanndickson ethanndickson changed the base branch from ethan/ci-mutagen-binary to graphite-base/110 March 12, 2025 05:44
@ethanndickson ethanndickson force-pushed the ethan/replace-dir-spaces branch from c34695c to ffd108f Compare March 12, 2025 05:46
@ethanndickson ethanndickson changed the base branch from graphite-base/110 to main March 12, 2025 05:47
@ethanndickson ethanndickson force-pushed the ethan/replace-dir-spaces branch from ffd108f to cbd9f57 Compare March 12, 2025 05:47
@ethanndickson ethanndickson changed the title refactor: replace space with hyphen in directory names refactor: replace spaces with hyphens in directory names Mar 12, 2025
Copy link
Member

@ThomasK33 ThomasK33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work.

Copy link
Member Author

ethanndickson commented Mar 13, 2025

Merge activity

  • Mar 12, 10:54 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 12, 10:54 PM EDT: A user merged this pull request with Graphite.

@ethanndickson ethanndickson merged commit e8e4004 into main Mar 13, 2025
4 checks passed
@ethanndickson ethanndickson deleted the ethan/replace-dir-spaces branch March 13, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants