Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc Small Improvements #30

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Misc Small Improvements #30

merged 4 commits into from
Sep 9, 2024

Conversation

scottstraughan
Copy link
Member

@scottstraughan scottstraughan commented Sep 9, 2024 •
edited
Loading

This PR:

  • Adds fs=true parameter support to Playground, enabling full screen mode on load
  • Adds fs=true parameter to share links of the full screen mode is currently enabled
  • Small text tweaks
  • Added missing comments
  • Better use of signals

@scottstraughan scottstraughan changed the title Add Full Screen Mode Params Flag Misc Small Improvements Sep 9, 2024
@scottstraughan scottstraughan merged commit cba9e31 into main Sep 9, 2024
6 checks passed
@scottstraughan scottstraughan deleted the playground-add-fullscreen-mode branch September 9, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlewis carlewis carlewis approved these changes

@codeplaymax codeplaymax Awaiting requested review from codeplaymax

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottstraughan @carlewis