Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor descriptor #137

Merged
merged 16 commits into from
Feb 1, 2024
Merged

Refactor descriptor #137

merged 16 commits into from
Feb 1, 2024

Conversation

t4c1
Copy link
Contributor

@t4c1 t4c1 commented Jan 31, 2024 •
edited
Loading

Splits committed_descriptor class into two classes - one for the public interface and one for implementation and splits the descriptor.hpp header into 3 - one for descriptor, one for committed_descriptor and one for committed_descriptor_impl.

Checklist

Tick if relevant:

  • New files have a copyright
  • New headers have an include guards
  • API is documented with Doxygen
  • New functionalities are tested
  • Tests pass locally
  • Files are clang-formatted

hjabird
hjabird reviewed Jan 31, 2024
View reviewed changes
@t4c1 t4c1 merged commit 14892b8 into main Feb 1, 2024
1 check passed
@t4c1 t4c1 deleted the refactor_descriptor branch February 1, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjabird hjabird hjabird approved these changes

@Rbiessy Rbiessy Rbiessy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t4c1 @hjabird @Rbiessy