Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host logging #135

Merged
merged 10 commits into from
Jan 31, 2024
Merged

Host logging #135

merged 10 commits into from
Jan 31, 2024

Conversation

t4c1
Copy link
Contributor

@t4c1 t4c1 commented Jan 29, 2024

Implemented host-side logging. Added a new category of log items - warnings - which is enabled by default. Warnings are never logged from kernels.

If logging of a category is enabled at compile time, it can be disabled at runtime using environment variables with the same names as CMake variables for enabling logging categories.

Checklist

Tick if relevant:

  • [N/A] New files have a copyright
  • [N/A] New headers have an include guards
  • API is documented with Doxygen
  • New functionalities are tested
  • Tests pass locally
  • Files are clang-formatted

Copy link
Contributor

@hjabird hjabird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include an example of the host trace output?

Copy link
Contributor

@FMarno FMarno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we need a logging section in the README now

Rbiessy
Rbiessy previously approved these changes Jan 29, 2024
FMarno
FMarno previously approved these changes Jan 29, 2024
hjabird
hjabird previously approved these changes Jan 29, 2024
@t4c1 t4c1 dismissed stale reviews from hjabird, FMarno, and Rbiessy via 84708f5 January 30, 2024 11:18
hjabird
hjabird previously approved these changes Jan 30, 2024
@t4c1 t4c1 merged commit 9732dd1 into main Jan 31, 2024
1 check passed
@t4c1 t4c1 deleted the host_logging branch January 31, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants