Skip to content

Fix failing unit tests on BMG #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2025

Conversation

joeatodd
Copy link
Collaborator

BMG has alignment restrictions which don't seem to exist on PVC. This PR:

  • Sets alignment-friendly shapes in various GEMM unit tests
  • Uses padding (i.e. pitched tensor) to fix some block copy unit tests

@FMarno
Copy link
Collaborator

FMarno commented Apr 22, 2025

If the test didn't meet the precondition of the BMG implementation, the test should probably have resulted in a skip when they hit this can_implement check:

cutlass::Status status = gemm_op.can_implement(arguments);

I'm guessing they didn't. Would now be a good time to update can_implement?

@joeatodd
Copy link
Collaborator Author

If the test didn't meet the precondition of the BMG implementation, the test should probably have resulted in a skip when they hit this can_implement check:

cutlass::Status status = gemm_op.can_implement(arguments);

I'm guessing they didn't. Would now be a good time to update can_implement?

I believe @t4c1 has done just that in #323

@aacostadiaz aacostadiaz merged commit 8864bf9 into codeplaysoftware:sycl-develop Apr 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants