Use Collective builder for benchmarks #302
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FMarno
commented
Apr 10, 2025
FMarno
force-pushed
the
collective_builder_for_benchmarks
branch
from
c7c4f8c to
bf21e0f
Compare
t4c1
reviewed
Apr 15, 2025
| }; | ||
|
|
||
| template <> | ||
| struct SubgroupTilingMap<Shape<_256,_256,_32>, cutlass::layout::RowMajor, cutlass::layout::RowMajor> { |
There was a problem hiding this comment.
Do you need those specializations just to match what was previously in benchmarks?
There was a problem hiding this comment.
No, my goal is make it more easily maintainable. If someone wants to tune one case then they can just add a specialization and move on.
There was a problem hiding this comment.
The benchmarks should be matched by the default case
…ilder_for_benchmarks
…ilder_for_benchmarks
…ilder_for_benchmarks
FMarno
force-pushed
the
collective_builder_for_benchmarks
branch
from
9ba2fcb to
ed88809
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the collective builders for benchmarks.
Also updates the collective builder to handle all the current benchmarks. I've gone for a two pronged approached where CTA tiles and matrix layouts can be mapped directly to a copy atom and subgroup layout, but there is also a fallback heuristic . The fallback is based on what the benchmarks were previously targetting and could probably be simplified and made more robust.