Skip to content

Organise SYCL Examples #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 8, 2025

Conversation

joeatodd
Copy link
Collaborator

@joeatodd joeatodd commented Apr 7, 2025

Moving PVC GEMM etc into their own dirs & improving consistency with upstream examples dir.

Copy link
Collaborator

@FMarno FMarno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me. I have a couple questions for my own interest though.

Copy link
Collaborator

@t4c1 t4c1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would it make sense to also move sycl implementation of example 35 gemm with online softmax?

@joeatodd
Copy link
Collaborator Author

joeatodd commented Apr 8, 2025

Looks good. Would it make sense to also move sycl implementation of example 35 gemm with online softmax?

I think the Nvidia hardware examples will be deprecated shortly in favour of sycl-cuda-compat.

Copy link
Collaborator

@aacostadiaz aacostadiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@joeatodd joeatodd merged commit 59cc478 into codeplaysoftware:sycl-develop Apr 8, 2025
8 checks passed
@joeatodd joeatodd deleted the reorg-examples branch April 8, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants