Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a skin with iPhone Dynamic Island support #7

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Add a skin with iPhone Dynamic Island support #7

merged 3 commits into from
Jul 30, 2024

Conversation

IvanoskiHarmonia
Copy link
Contributor

This PR adds the following skins and skin maps for IPhone: 15, 15 Plus, 15 Pro, 15 Pro Max

@IvanoskiHarmonia
Copy link
Contributor Author

I personally think that phones outside of phone dir should be deleted @shai-almog.
phones dir is practically identical all phone dirs outside of phones dir. I am not sure how these skins are handled in the main repo. Do you want me to delete all those duplicate folders outside of phones dir?

@IvanoskiHarmonia IvanoskiHarmonia mentioned this pull request Jul 29, 2024
Closed
@shai-almog shai-almog merged commit d1c2fad into codenameone:master Jul 30, 2024
1 check passed
@shai-almog
Copy link
Contributor

@IvanoskiHarmonia thanks!
I'm not sure if there's some dependency on that directory. Maybe @shannah has some thoughts on this.

@IvanoskiHarmonia IvanoskiHarmonia deleted the issue-3762 branch July 30, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IvanoskiHarmonia @shai-almog