Skip to content

Commit

Permalink
Set default playServicesVersion back to 12.0.1.
Browse files Browse the repository at this point in the history
Separated out versions for firebase-core and firebase-messaging, setting default at 12.0.1.  Will investigate compatible new version for next release.
  • Loading branch information
shannah committed Feb 28, 2023
1 parent b723c9e commit fbb4b75
Showing 1 changed file with 15 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ public File getGradleProjectDirectory() {

private static final boolean isMac;

private String playServicesVersion = "16.0.0";
private String playServicesVersion = "12.0.1";
private static final Map<String,String> defaultPlayServiceVersions = new HashMap<>();
static {
// Defaults obtained from https://developers.google.com/android/guides/setup
Expand Down Expand Up @@ -325,6 +325,12 @@ public File getGradleProjectDirectory() {
defaultPlayServiceVersions.put("vision", "20.1.3");
defaultPlayServiceVersions.put("wallet", "19.1.0");
defaultPlayServiceVersions.put("wearable", "18.0.0");

// TODO: See what an appropriate default version is for firebase
// Setting to 12.0.1 for now only to match the previous google play services default.
defaultPlayServiceVersions.put("firebase-core", "12.0.1");
defaultPlayServiceVersions.put("firebase-messaging", "12.0.1");
defaultPlayServiceVersions.put("gcm", "12.0.1");
}

private Map<String,String> playServiceVersions = new HashMap<>();
Expand Down Expand Up @@ -1129,6 +1135,8 @@ public void usesClassMethod(String cls, String method) {
}
}
request.putArgument("android.playServicesVersion", playServicesVersion);
request.putArgument("android.firebaseCoreVersion", request.getArg("android.firebaseCoreVersion", getDefaultPlayServiceVersion("firebase-core")));
request.putArgument("android.firebaseMessagingVersion", request.getArg("android.firebaseMessagingVersion", getDefaultPlayServiceVersion("firebase-messaging")));

debug("-----USING PLAY SERVICES VERSION "+playServicesVersion+"----");

Expand Down Expand Up @@ -1156,11 +1164,11 @@ public void usesClassMethod(String cls, String method) {
debug("Adding firebase core to gradle dependencies.");
debug("Play services version: " + request.getArg("var.android.playServicesVersion", ""));
debug("gradleDependencies before: "+request.getArg("gradleDependencies", ""));
request.putArgument("gradleDependencies", request.getArg("gradleDependencies", "") + "\n"+compile+" \"com.google.firebase:firebase-core:${var.android.playServicesVersion}\"\n");
request.putArgument("gradleDependencies", request.getArg("gradleDependencies", "") + "\n"+compile+" \"com.google.firebase:firebase-core:${var.android.firebaseCoreVersion}\"\n");
debug("gradleDependencies after: "+request.getArg("gradleDependencies", ""));
}
if (!request.getArg("gradleDependencies", "").contains("com.google.firebase:firebase-messaging")) {
request.putArgument("gradleDependencies", request.getArg("gradleDependencies", "") + "\n"+compile+" \"com.google.firebase:firebase-messaging:${var.android.playServicesVersion}\"\n");
request.putArgument("gradleDependencies", request.getArg("gradleDependencies", "") + "\n"+compile+" \"com.google.firebase:firebase-messaging:${var.android.firebaseMessagingVersion}\"\n");
}
}

Expand Down Expand Up @@ -4090,6 +4098,10 @@ private void initPlayServiceVersions(BuildRequest request) {
String playServiceKey = arg.substring("android.playService.".length());
if (playServiceKey.equals("appInvite")) {
playServiceKey = "app-invite";
} else if (playServiceKey.equals("firebaseCore")) {
playServiceKey = "firebase-core";
} else if (playServiceKey.equals("firebaseMessaging")) {
playServiceKey = "firebase-messaging";
}
String playServiceValue = request.getArg(arg, null);
if (playServiceValue == null || "true".equals(playServiceValue) || "false".equals(playServiceValue)) {
Expand Down

0 comments on commit fbb4b75

Please sign in to comment.