Skip to content

Commit

Permalink
Fixed another compilation issue... Damn CI doesn't detect that...
Browse files Browse the repository at this point in the history
  • Loading branch information
shai-almog committed Apr 29, 2022
1 parent 9a94e2c commit 80b84a0
Showing 1 changed file with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -779,27 +779,27 @@ private static PushActionCategory[] getInstalledPushActionCategories(Context con
public static PendingIntent createPendingIntent(Context ctx, int value, Intent intent) {
if (android.os.Build.VERSION.SDK_INT >= 23) {
// PendingIntent.FLAG_IMMUTABLE
return PendingIntent.getActivity(ctx, value, newIntent, 67108864);
return PendingIntent.getActivity(ctx, value, intent, 67108864);
} else {
return PendingIntent.getActivity(ctx, value, newIntent, PendingIntent.FLAG_CANCEL_CURRENT);
return PendingIntent.getActivity(ctx, value, intent, PendingIntent.FLAG_CANCEL_CURRENT);
}
}

public static PendingIntent getPendingIntent(Context ctx, int value, Intent intent) {
if (android.os.Build.VERSION.SDK_INT >= 23) {
// PendingIntent.FLAG_IMMUTABLE
return PendingIntent.getService(ctx, value, newIntent, 67108864);
return PendingIntent.getService(ctx, value, intent, 67108864);
} else {
return PendingIntent.getService(ctx, value, newIntent, PendingIntent.FLAG_CANCEL_CURRENT);
return PendingIntent.getService(ctx, value, intent, PendingIntent.FLAG_CANCEL_CURRENT);
}
}

public static PendingIntent getBroadcastPendingIntent(Context ctx, int value, Intent intent) {
if (android.os.Build.VERSION.SDK_INT >= 23) {
// PendingIntent.FLAG_IMMUTABLE
return PendingIntent.getBroadcast(ctx, value, newIntent, 67108864);
return PendingIntent.getBroadcast(ctx, value, intent, 67108864);
} else {
return PendingIntent.getBroadcast(ctx, value, newIntent, PendingIntent.FLAG_CANCEL_CURRENT);
return PendingIntent.getBroadcast(ctx, value, intent, PendingIntent.FLAG_CANCEL_CURRENT);
}
}

Expand Down

2 comments on commit 80b84a0

@javieranton-zz
Copy link
Contributor

@javieranton-zz javieranton-zz commented on 80b84a0 Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a fix for the Implicit pending intent message on Google's Dashboard? I noticed it didn't go away with 7.0.71

image

@shai-almog
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in 7.0.72 and should be on the build servers right now.

Please sign in to comment.